search

equinor / iec63131

Other
8 stars 8 forks source link

Update LegalValues for terminal attribute detail “CommunicationType” as per IEC PAS 63131? #68

Closed AshokaK0 closed 1 year ago

AshokaK0 commented 2 years ago

Reference is made to the terminal attribute detail “CommunicationType” in the AML library. Name: CommunicationType Description: Type of signal communication. Value: Data Type: xs:string LegalValues: [0] Signal Interface [1] Bus Interface

As per “Table D.7 – Instrument signals” in IEC PAS 63131, the instrument signals are represented as below.

  1. General signal, e.g. logic software signal within a node or hardwired signal from transmitter to SAS. Can also be used for bus signals and serial lines.
  2. Data communication link, i.e. bus or serial line. The signal line reflects the logic end points of the signal, and not the actual bus topology.

The existing LegalValues in the AML library could be revised for better understanding of the options and selection of instrument signal types.

AlexTxen commented 1 year ago

Discussions have been taken in the workshop held on 21.06.2023, refer to item 4. https://github.com/equinor/iec63131/blob/2c8fa87426e072459c5afc61afd97b1ce53cd28c/MOM%20AML%20Library%200.0.11%20workshop.docx

It has been agreed to use 'GeneralSignal' and 'DataCommunicationLink' to match wording of IEC63131.

AlexTxen commented 1 year ago

Implemented in 1f1f4a453ed53ab4ba8fcb36505750fa93cc6635 Issue can be closed.

Changed Legal Values for attribute 'CommunicationType' to 'GeneralSignal'/'DataCommunicationLink': image