equinor / iec63131

Other
8 stars 8 forks source link

Changes for 0.0.11 version #79

Closed AlexTxen closed 1 year ago

AlexTxen commented 1 year ago

Closes #3, closes #5, closes #34, closes #49, closes #53, closes #58, closes #60, closes #63, closes #64, closes #68, closes #70, closes #77 Also ref. #66, #69

Erik0x42 commented 1 year ago

Attribute 'Annunciation' has not been added to the interface class 'BinaryOutAnnunciated', but has been added to external interface Y of the MB class (). Is this what we want? Should external interface AHH on the MA class, for example, have the 'Annunciation' attribute?

For reference, the attribute is present on interface class 'SequenceFlowTimeout', and also on external interfaces with the same name on Step and Start sequence types.

AlexTxen commented 1 year ago

Attribute 'Annunciation' has not been added to the interface class 'BinaryOutAnnunciated', but has been added to external interface Y of the MB class (). Is this what we want? Should external interface AHH on the MA class, for example, have the 'Annunciation' attribute?

For reference, the attribute is present on interface class 'SequenceFlowTimeout', and also on external interfaces with the same name on Step and Start sequence types.

This attribute is present on interfaces, where it is needed to distinguish between event/warning/alarm. AHH is alarm by definition, so "annunciation" attribute on such terminals would be redundant.