search

equinor / isar

Integration and Supervisory control of Autonomous Robots
Eclipse Public License 2.0
19 stars 34 forks source link

Remove 'start_time' in 'InspectionMetadata' #368

Open tsundvoll opened 1 year ago

tsundvoll commented 1 year ago

Describe the improvement you would like to see Remove the 'start_time' attribute from the 'InspectionMetadata' class in 'src/robot_interface/models/inspection/inspection.py'. Time is anyways baked into the 'time_indexed_pose' attribute. Remember to update everywhere the class is used, also in the different robot repositories.

How will this change existing functionality? I can't see that start time is used anywhere now, so it will not break any existing functionality.

aeshub commented 1 year ago

This issue has automatically been marked as stale as there has been no activity for 60 days.

Christdej commented 1 year ago

Would it make more sense to change TimeIndexedPose to Pose and keep "start_time"?

aeshub commented 1 year ago

This issue has automatically been marked as stale as there has been no activity for 60 days.

aeshub commented 1 week ago

This issue has automatically been marked as stale as there has been no activity for 60 days.