equinor / komodo

Komodo is a software distribution system used internally in Equinor
GNU Affero General Public License v3.0
5 stars 23 forks source link

komodo-transpiler needs to sort packages inside releases/matrices #158

Open hnformentin opened 4 years ago

hnformentin commented 4 years ago

komodo-transpiler currently sorts alphabetically .yml files only for transpilled files (e.g. in release folder as 2020.10.b5-py36-rhel7.yml). The files inside releases/matrices are kept in the wrong alphabetical order (e.g. 2020.10.b5.yml). A suggestion to fix is first rewrite files in releases/matrix with write_to_file function (which sorts alphabetically) before transpile_releases function in release_transpiler.

sondreso commented 4 years ago

I'm not so sure that the transpiler should sort the matrix release, since we want the matrix release to be sorted in the repository. This sounds like it belongs in the prettier (running it locally it would sort your release, and in CI it will check that your release is sorted).