search

equinor / komodo

Komodo is a software distribution system used internally in Equinor
GNU Affero General Public License v3.0
5 stars 23 forks source link

Refactor komodo insert proposals #467

Closed jonathan-eq closed 9 months ago

jonathan-eq commented 9 months ago

Resolves #468

jonathan-eq commented 9 months ago

Quick question. In most places in insert_proposals, we use update and upgrade as the same thing, but it is not necessarily the same thing. I think we should only use update. This includes renaming upgrade_proposals to update_proposals. Example: A broken version of a package is added to the release, and we would have to downgrade. This should not be added in a file called upgrade_proposals.yml.

berland commented 9 months ago

Are the lines you have changed covered by the existing tests with a mocked github service?

jonathan-eq commented 9 months ago

No, but now that it is easier to test, I will add some good unit tests.

jonathan-eq commented 9 months ago

I have added tests now.