search

equinor / komodoenv

Komodoenv is the virtualenv of the Komodo world
GNU General Public License v3.0
1 stars 3 forks source link

Don't crash when Python doesn't have ctypes installed #31

Closed pinkwah closed 1 year ago

pinkwah commented 3 years ago

We use ctypes to test whether the user is on NFS or not via a Linux-only function: https://github.com/equinor/komodoenv/blob/master/komodoenv/statfs.py

This is just a nice feature for the user, and we shouldn't crash if the user is missing the ctypes module (which can happen on particularly thin Python installs)

JensGM commented 3 years ago

ctypes is part of python and is usually present. It is an optional module, but it is present in the redhat builtin python distribution. So I think the issue here is related to the cloning of python rather than ctypes missing

pinkwah commented 3 years ago

It's still a nice polishing opportunity. ctypes is an optional component, but so is the functionality we're using it for.

xjules commented 1 year ago

Is this issue still relevant @pinkwah ?