Cannot run "npm install" on projects that use this fork of react-native-msal without having yarn installed

[tormodAase]

Bug Description: If a project uses this fork as a dependency, npm install won't work unless you have yarn installed on your machine.

Steps To Reproduce:

• Uninstall yarn (if it is installed on your computer)
• (not sure if needed) delete node_modules folder in the project you want to reproduce this in (e.g. OM Inspection)
• Run npm install in the above project

Expected Behavior: Installation of packages should work just fine

Environment Information:

• react-native-msal version: f1069d3 (though I believe this will happen in any commit)
• react-native version: any
• Platform: iOS

Additional Information: I believe this happens because we use this package directly from github, without building it first.

[tormodAase]

The bug was found by Henning. @dansvend @HaakonSvane

[Goostavo]

Related to the bootstrap file and the package.json. Both are using commands that depends on Yarn.

This discussion on Stack Overflow show two nice solutions. Using the environment variable that holds the default npm or yarn, or adding a small dev module to the project that detects and uses the default. https://stackoverflow.com/questions/41647961/package-json-scripts-that-work-with-npm-and-yarn

[MAgungHKM]

From my findings, the root cause is expo-module-scripts. That package has npx bash file which supposed to detect wether you use yarn exec or npx, but the if condition appears to be incorrect, as we can see over at https://github.com/expo/expo/commit/d295e37d1e623ca8abe067ae7dbb2841bc81e96d.

So either update the expo-modules-scripts package or apply a patch-package to that specific bash file.