search

equinor / segyio

Fast Python library for SEGY files.
Other
480 stars 215 forks source link

catch2: v2.2.3 -> v2.13.9 #531

Closed AtilaSaraiva closed 2 years ago

AtilaSaraiva commented 2 years ago

Hello folks from Equinor,

I've been packaging segyio for the Nix package manager but I stumbled upon the catch2 error described here. It has been solved in more recent versions of catch2, so I'm making this PR to bump the version in order to fix it.

Cheers!

tasansal commented 2 years ago

+1 for this. The issue I encountered is on OS X ARM64 (aarch64). segyio wasn't compiling due to the lack of aarch64 assembly instructions for the older version of catch2.

I can confirm that with this change, I could compile segyio from the source on an Apple M1 device.

It will help with #534

ErlendHaa commented 2 years ago

Hi!

Thank you for the contribution, and sorry for the late reply! If you could rebase on master to allow CI to run once more, then I will happy approve and merge this :)

AtilaSaraiva commented 2 years ago

Oh no problem, just gimme some minutes

AtilaSaraiva commented 2 years ago

Done!

AtilaSaraiva commented 2 years ago

Thanks!