search

equinor / segyio

Fast Python library for SEGY files.
Other
490 stars 218 forks source link

Fix attribute error in setup.py #576

Open sveinung-r opened 4 months ago

sveinung-r commented 4 months ago

This line was causing a error due to an update to scikit-build. The issue was that the setuptools.command.test module is not put into the symbol table by the setuptools import, but it was put there during the skbuild import causing it to be available. Due to changes in scikit-build this is no longer the case and the line gives an AttributError.

The rationale for this line was that scikit-builds test command implied develop (this was obnoxious), something that is no longer true. There is thus no longer any reason to keep this line, so we can fix this issue by simply removing it.

tjni commented 1 month ago

@sveinung-r Hello! I'm trying to fix the build for this package in nixpkgs, which is broken due to this error.

  1. I notice quite a few commits. Are they unrelated to fix CI issues, or are they related to this change?
  2. What's the status of this patch being merged?

Thank you for creating this patch and doing the leg work of figuring out what is going on.

ajaust commented 1 month ago

Hei @tjni,

Awesome that you package segyio for Nix. :)

I cannot comment on the first point, but I think it is still the plan to merge the PR. The PR was blocked due to the failing test on aarch64. The issue was tracked down to be an issue with np.unique. Afaik that was fixed, but we were still waiting for a new release of NumPy for an older Python release that we support (I think 3.9). I see that there are several new NumPy releases. We will check if can merge this PR soon.