search

equinor / septic-config-generator

SEPTIC config generator
MIT License
4 stars 0 forks source link

refactor: various cleanup #257

Closed einarsi closed 7 months ago

einarsi commented 7 months ago

BEGIN_COMMIT_OVERRIDE refactor: clean up lib.rs

refactor: clean up overwriting of existing output file END_COMMIT_OVERRIDE

github-actions[bot] commented 7 months ago

Test Results

56 tests  ±0   56 :white_check_mark: ±0   0s :stopwatch: ±0s  1 suites ±0    0 :zzz: ±0   1 files   ±0    0 :x: ±0 

Results for commit 8c8bd447. ± Comparison against base commit 14e1e488.

This pull request removes 4 and adds 4 tests. Note that renamed tests count towards both. ``` septic-config-generator ‑ tests::collect_file_list_works septic-config-generator ‑ tests::timestamps_newer_than_errors_on_missing_infile septic-config-generator ‑ tests::timestamps_newer_than_errors_on_missing_outfile septic-config-generator ‑ tests::timestamps_newer_than_works ``` ``` septic-config-generator ‑ commands::make::tests::collect_file_list_works septic-config-generator ‑ commands::make::tests::timestamps_newer_than_errors_on_missing_infile septic-config-generator ‑ commands::make::tests::timestamps_newer_than_errors_on_missing_outfile septic-config-generator ‑ commands::make::tests::timestamps_newer_than_works ```
github-actions[bot] commented 7 months ago

Test Results

56 tests  ±0   56 :white_check_mark: ±0   0s :stopwatch: ±0s  1 suites ±0    0 :zzz: ±0   1 files   ±0    0 :x: ±0 

Results for commit 8c8bd447. ± Comparison against base commit 14e1e488.

This pull request removes 4 and adds 4 tests. Note that renamed tests count towards both. ``` septic-config-generator ‑ tests::collect_file_list_works septic-config-generator ‑ tests::timestamps_newer_than_errors_on_missing_infile septic-config-generator ‑ tests::timestamps_newer_than_errors_on_missing_outfile septic-config-generator ‑ tests::timestamps_newer_than_works ``` ``` septic-config-generator ‑ commands::make::tests::collect_file_list_works septic-config-generator ‑ commands::make::tests::timestamps_newer_than_errors_on_missing_infile septic-config-generator ‑ commands::make::tests::timestamps_newer_than_errors_on_missing_outfile septic-config-generator ‑ commands::make::tests::timestamps_newer_than_works ```

:recycle: This comment has been updated with latest results.

codecov[bot] commented 7 months ago

Codecov Report

Attention: Patch coverage is 73.63636% with 58 lines in your changes are missing coverage. Please review.

Project coverage is 78.42%. Comparing base (14e1e48) to head (8c8bd44).

Files Patch % Lines
src/commands/make.rs 71.21% 57 Missing :warning:
src/datasource.rs 95.45% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #257 +/- ## ========================================== - Coverage 78.47% 78.42% -0.05% ========================================== Files 9 8 -1 Lines 1663 1664 +1 ========================================== Hits 1305 1305 - Misses 358 359 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.