search

equinor / tagreader-python

A Python package for reading trend data from the OSIsoft PI and Aspen InfoPlus.21 historians
https://equinor.github.io/tagreader-python/
MIT License
45 stars 18 forks source link

Tag optional or not? #360

Open smolvik1 opened 2 months ago

smolvik1 commented 2 months ago

Perhaps a silly question, but is tag an Optional parameter in search as per the type hinting or not? https://github.com/equinor/tagreader-python/blob/25743aca87f8cc0979569e756b2a445719185d16/tagreader/web_handlers.py#L444

smolvik1 commented 2 months ago

c = tagreader.IMSClient("GFB", "aspenone") c.connect() c.search(desc='*Ringrom*')

Yields Tag is required.

Doing the same for a piwebapi client, e.g PINO, results are returned. Assuming then that the aspenone client requires the tag input when searching, whereas the piwebapi client does not.