Test reading Cache on expired sas token

equinor / vds-slice

Web API for fast access of arbitrary seismic slices from VDS data

GNU Affero General Public License v3.0

3 stars 8 forks source link

Test reading Cache on expired sas token #241

Closed yngve793 closed 6 months ago

yngve793 commented 9 months ago

We are currently storing previous computed results in cache. It would be useful to test the following after an initial request:

Verify that a new request with valid SAS token is read from cache
Verify that a new request with invalid SAS token is ignored and no data is returned
Verify that a new request with no SAS token is ignored and no data is returned

achaikou commented 9 months ago

Why shouldn't we be able to access cache results after initial token has expired?? Doesn't it defeat the purpose?

sas-tokens are not included in cache and have nothing to do with it. We want short-lived sas tokens (like 1 minute) and long-lived cache which is accessible as long as user has a new shiny sas token currently valid for actual data.

yngve793 commented 9 months ago

Bad formulation, issue rephrased.

AdilKhurshid commented 9 months ago

I have verified all the points mentioned in the task, and they are all working as we are expecting. We can now close this issue 😊

yngve793 commented 9 months ago

Ok, that is fine by me.