search

equinor / videx-wellog

Well log components
https://equinor.github.io/videx-wellog/
MIT License
20 stars 7 forks source link

Update and fix storybook #226

Closed fbosquet-azpn closed 4 months ago

fbosquet-azpn commented 4 months ago

The purpose is to upgrade the old storybook example.

The old story book in examples/plain-javascript-example was still in version 5 of storybook and Snyk was reporting several vulnerabilities. Beside it was not longer possible to start storybook using npm run storybook, we were getting an error start-storybook not found. The storybook version was so old that it failed to upgrade using the standard npx storybook@7 upgrade comande.

I have then created a new storybook from scratch and copy over all existings stories.

I have then fixup the videx-log types hierarchy for Plot/PlotOptions and Track/TrackOptions using Generic programing. Before those fixes, all the stories in the storybook did not render properly (all empty pages like the movie in issue #182 )

https://github.com/equinor/videx-wellog/assets/68541104/b2692649-c4a8-4da8-b7ad-bf40b54af4a0

GuillaumeVix commented 4 months ago

Thanks for doing the changes and creating the pull request, we will have a look at it!

fbosquet-azpn commented 4 months ago

I have also taken the opportunity to