search

equinor / webviz-core-components

Discipline agnostic Webviz and Dash components.
https://github.com/orgs/equinor/projects/24
MIT License
15 stars 16 forks source link

Change React to StrictMode. #131

Open rubenthoms opened 3 years ago

rubenthoms commented 3 years ago

In order to improve code quality, all components should be written/changed to conform to React Strict Mode (https://reactjs.org/docs/strict-mode.html).

emadbaqeri commented 3 years ago

@rubenthoms, @anders-kiaer as I have searched for this feature <React.StrictMode> web sould have this feature in our main file I mean in app file or separately in every component. could you please help me doing this, I would like to work on this issue.

rubenthoms commented 3 years ago

Hey @emadbaqeri. Glad to see that you'd like to help out in this project :smiley: I'm afraid, but despite the label (which we should probably remove) this is not really a good issue to start with. Why so? This is because starting using strict mode might cause a lot of issues in multiple components which would make this issue become quite large. Moreover, we haven't quite decided yet when to address this change. However, your help would still be a lot appreciated on other tasks. Could you consider to have a look at some other issues? Some good candidates are:

Looking forward to hearing from you!

emadbaqeri commented 3 years ago

Hey @rubenthoms I'm really happy that you respect a newbie developer and you put your time on halping me. It's my honor to work with you cool guys. I'm going to give it a try and do my best for working on those issues.