search

equinor / webviz-core

GNU Lesser General Public License v3.0
2 stars 3 forks source link

fix: component update for dash 0.40.0 #13

Closed orjanbp closed 5 years ago

orjanbp commented 5 years ago

Re-requesting pull to fix component updates for Dash 0.40.0, after last attempted fix had some oversights.

resolves #7

orjanbp commented 5 years ago

All necessary components should now be 0.40 compatible. They're building and the Dash example presentations are running.

The linter is not entirely happy with the solution, but I've opted to drown out its noise in this PR so we can focus on getting a fix out already -- and then refactor for a better solution later. It looks like it should work, it just could be more elegant.

orjanbp commented 5 years ago

Trying to update the tests to run as if the props are coming in through _dashprivate_layout, but for some reason the test snapshot for <Layout> decides to omit its children. Even though the built component works as it should in Dash.

eivindjahren commented 5 years ago

Trying to update the tests to run as if the props are coming in through _dashprivate_layout, but for some reason the test snapshot for <Layout> decides to omit its children. Even though the built component works as it should in Dash.

It seems like titles are given the value undefined. When I start examples/map_example.py and go to localhost:8050/undefined I get the first subpage.

orjanbp commented 5 years ago

Could we take a moment to sit down together and figure this out @eivindjahren ? I feel like I've been staring myself a bit blind at that part.