equinor / webviz-ert

ERT webviz plugins
GNU General Public License v3.0
13 stars 25 forks source link

Plot viewer: x-axis range is wrongly extended to the past #376

Closed hnformentin closed 3 months ago

hnformentin commented 2 years ago

Describe the bug In the plot viewer of webviz-ert, the range of x-axis is extended back when plotting the pred_ref case. We compared to ert gui and this behavior is not present there (see images).

To Reproduce Steps to reproduce the behavior:

  1. Get a copy of the data set of Drogon tutorial (tar xhf /scratch/fmu/share/drogon/course/drogon_current.tar.gz)
  2. source /prog/res/komodo/stable/enable
  3. cd drogon_20211115_12-12/resmod/ff/21.0.1/ert/model
  4. ert gui drogon_ahm.ert
  5. Select data as indicated in the image

Expected behavior The x-axis should not be displaced to an early date because the case pred_ref is loaded.

Screenshots Webviz-ert compared to ert gui:

Screenshot from 2022-08-18 14-38-46

Screenshot from 2022-08-18 14-34-26

hnformentin commented 2 years ago

By the way, why the color of the observations is different?

valentin-krasontovitsch commented 2 years ago

By the way, why the color of the observations is different?

you mean black in the ert gui, and red in webviz-ert?

hnformentin commented 2 years ago

By the way, why the color of the observations is different?

you mean black in the ert gui, and red in webviz-ert?

Yes...

valentin-krasontovitsch commented 2 years ago

that's a good question :sweat_smile:

hnformentin commented 2 years ago

I noticed the difference, because red–green color blindness is the most common form, so I would avoid having both in the same plot...

valentin-krasontovitsch commented 2 years ago

it's a good point! i know way too little about barrier-free design (is that the right term?), and also think about it too litte.

andreas-el commented 2 years ago

The issue seems to be caused by a negative value (-1) present in the timestamp series. This is plotted differently in webviz and the gui plotter, where webviz allows this as a valid datapoint and the gui plotter omits drawing it.

DanSava commented 3 months ago

Tested this with the latest drogon_20240807_12_21 and the issue is no longer present.

image