equinor / webviz-ert

ERT webviz plugins
GNU General Public License v3.0
13 stars 25 forks source link

Fix superimposing layout 378 #383

Closed valentin-krasontovitsch closed 2 years ago

valentin-krasontovitsch commented 2 years ago

Issue Closes #378

Approach Increase height of columns in response view; Let labels overflow and show overflow in parameter comparison view.

Pre review checklist

hnformentin commented 2 years ago

It seems that the code is fine. Would you mind to add some screenshots of the views affected before and after? Also, Jenkins is not passing. Not sure if this is related to this PR, but could you please take a look before firing tests again?

Started by upstream project "komodo_testing/x-webviz-ert" build number 528 originally caused by: GitHub pull request #383 of commit 1a2d74bacdba3ad3fcde755e54c84590225460a7, no merge conflicts. [Pipeline] Start of Pipeline [Pipeline] library Loading library testKomodo@main Attempting to resolve main from remote references...

git --version # timeout=10 git --version # 'git version 2.30.2' using GIT_ASKPASS to set credentials ertomatic with token as password Setting http proxy: www-proxy.statoil.no:80 git ls-remote -h -- https://github.com/equinor/komodo.git # timeout=10 Found match: refs/heads/main revision 74e05d1dea7845e2d4a4482573bdd5a517392d90 Selected Git installation does not exist. Using Default The recommended git tool is: NONE using credential 87f60f52-6280-4811-9f6a-79acabf93833 git rev-parse --resolve-git-dir /var/jenkins_home/workspace/komodo_testing/webviz-ert-pr@libs/c9775ee3e1032fcce7b6d30e36d1f442b077ce4d17e7e7fac124f3222fc156b4/.git # timeout=10 Fetching changes from the remote Git repository git config remote.origin.url https://github.com/equinor/komodo.git # timeout=10 Fetching without tags Fetching upstream changes from https://github.com/equinor/komodo.git git --version # timeout=10 git --version # 'git version 2.30.2' using GIT_ASKPASS to set credentials ertomatic with token as password Setting http proxy: www-proxy.statoil.no:80 git fetch --no-tags --force --progress -- https://github.com/equinor/komodo.git +refs/heads/:refs/remotes/origin/ # timeout=10 Checking out Revision 74e05d1dea7845e2d4a4482573bdd5a517392d90 (main) git config core.sparsecheckout # timeout=10 git checkout -f 74e05d1dea7845e2d4a4482573bdd5a517392d90 # timeout=10 Commit message: "Switch from master to main" git rev-list --no-walk 74e05d1dea7845e2d4a4482573bdd5a517392d90 # timeout=10 [Pipeline] node Running on (f_scout_ci) st-linapp1197 § RHEL7 in /tmp/jenkins-scout-f_scout_ci/workspace/komodo_testing/webviz-ert-pr [Pipeline] { [Pipeline] withEnv [Pipeline] { [Pipeline] ansiColor [Pipeline] {

[Pipeline] stage [Pipeline] { (Pre-setup) [Pipeline] deleteDir [Pipeline] sh

  • source /prog/res/komodo/bleeding-py38-rhel7/enable ++ disable_komodo preserve_disable_komodo ++ [[ -v _PRE_KOMODO_PATH ]] ++ [[ -v _PRE_KOMODO_MANPATH ]] ++ [[ -v _PRE_KOMODO_LD_LIBRARY_PATH ]] ++ '[' -n /usr/bin/sh -o -n '' ']' ++ hash -r ++ [[ -v _PRE_KOMODO_PS1 ]] ++ unset KOMODO_RELEASE ++ unset KOMODO_ROOT ++ unset ERT_LSF_SERVER ++ '[' '!' preserve_disable_komodo = preserve_disable_komodo ']' ++ export KOMODO_RELEASE=bleeding-py38-rhel7 ++ KOMODO_RELEASE=bleeding-py38-rhel7 ++ export _PRE_KOMODO_PATH=/opt/rh/rh-git227/root/usr/bin:/usr/local/bin:/usr/bin:/global/distbin:/global/bin:/global/SP/bin:/global/bin ++ _PRE_KOMODO_PATH=/opt/rh/rh-git227/root/usr/bin:/usr/local/bin:/usr/bin:/global/distbin:/global/bin:/global/SP/bin:/global/bin ++ export PATH=/prog/res/komodo/bleeding-py38-rhel7/root/bin:/opt/rh/rh-git227/root/usr/bin:/usr/local/bin:/usr/bin:/global/distbin:/global/bin:/global/SP/bin:/global/bin ++ PATH=/prog/res/komodo/bleeding-py38-rhel7/root/bin:/opt/rh/rh-git227/root/usr/bin:/usr/local/bin:/usr/bin:/global/distbin:/global/bin:/global/SP/bin:/global/bin ++ export _PRE_KOMODO_MANPATH=/opt/rh/rh-git227/root/usr/share/man: ++ _PRE_KOMODO_MANPATH=/opt/rh/rh-git227/root/usr/share/man: ++ export MANPATH=/prog/res/komodo/bleeding-py38-rhel7/root/share/man:/opt/rh/rh-git227/root/usr/share/man: ++ MANPATH=/prog/res/komodo/bleeding-py38-rhel7/root/share/man:/opt/rh/rh-git227/root/usr/share/man: ++ export _PRE_KOMODO_LD_LIBRARY_PATH=/opt/rh/httpd24/root/usr/lib64 ++ _PRE_KOMODO_LD_LIBRARY_PATH=/opt/rh/httpd24/root/usr/lib64 ++ export LD_LIBRARY_PATH=/prog/res/komodo/bleeding-py38-rhel7/root/lib:/prog/res/komodo/bleeding-py38-rhel7/root/lib64:/opt/rh/httpd24/root/usr/lib64 ++ LD_LIBRARY_PATH=/prog/res/komodo/bleeding-py38-rhel7/root/lib:/prog/res/komodo/bleeding-py38-rhel7/root/lib64:/opt/rh/httpd24/root/usr/lib64 ++ export _PRE_KOMODO_PS1= ++ _PRE_KOMODO_PS1= ++ export 'PS1=(bleeding-py38-rhel7) ' ++ PS1='(bleeding-py38-rhel7) ' ++ local_script=/prog/res/komodo/bleeding-py38-rhel7/root/../local ++ '[' -e /prog/res/komodo/bleeding-py38-rhel7/root/../local ']' ++ source /prog/res/komodo/bleeding-py38-rhel7/root/../local ++++ hostname +++ host=st-linapp1197.st.statoil.no ++++ echo st-linapp1197.st.statoil.no ++++ cut -d - -f 1 +++ location=st +++ case ${location} in +++ export ERT_LSF_SERVER=st-grid03.st.statoil.no +++ ERT_LSF_SERVER=st-grid03.st.statoil.no ++ '[' -n /usr/bin/sh -o -n '' ']' ++ hash -r ++ '[' -d /prog/res/komodo/bleeding-py38-rhel7/root/../motd/scripts ']' ++ '[' -d /prog/res/komodo/bleeding-py38-rhel7/root/../motd/messages ']'
  • komodoenv -rbleeding-py38-rhel7 --no-update test-kenv /tmp/jenkins-scout-f_scout_ci/workspace/komodo_testing/webviz-ert-pr@tmp/durable-0b00b42d/script.sh: /prog/res/komodo/bleeding-py38-rhel7/root/bin/komodoenv: /tmp/jenkins-komodo-f_komodo/workspace/x-build-some-other/bleeding-py38-rhel7/: bad interpreter: Permission denied [Pipeline] } [Pipeline] // stage [Pipeline] stage [Pipeline] { (Run Tests) Stage "Run Tests" skipped due to earlier failure(s) [Pipeline] } [Pipeline] // stage [Pipeline] }

[Pipeline] // ansiColor [Pipeline] } [Pipeline] // withEnv [Pipeline] } [Pipeline] // node [Pipeline] End of Pipeline ERROR: script returned exit code 126 Finished: FAILURE

valentin-krasontovitsch commented 2 years ago

coolio! i guess i should have mentioned that, sorry, there are some images in the issue, and also one or two questions - i really should not rely on the github notifications...

please see if the images there suffice.

also, gonna check out the jenkins!

valentin-krasontovitsch commented 2 years ago

jenkins, retest this please.

original jenkins failure due to bleeding not having built successfully, cf. slack question[INTERNAL LINK]

valentin-krasontovitsch commented 2 years ago

results of this change, visualized:

i found a way of hacking the labels visible after all: move them down, and set overflow to visible. but: on mouseover, one sees that the border of the container "cuts off" the labels, see screenshots.

mouse not on container, borders not visible, OK:

hack-ok

mouse on container, borders visible, it's subtle but off:

hack-borders

valentin-krasontovitsch commented 2 years ago

jenkins build aborted by user. orginally passed, before my comment edit triggered a rerun. merging now.

hnformentin commented 2 years ago

Nice @valentin-krasontovitsch. I tested on the context that led the bug to be reported and it worked. Screenshot from 2022-08-30 13-57-24