equinor / webviz-ert

ERT webviz plugins
GNU General Public License v3.0
13 stars 25 forks source link

Simplify dash timeout #429

Closed kwinkunks closed 11 months ago

kwinkunks commented 1 year ago

Issue Timeouts were set in a few different places, and we're trying to change them and add others to cope with Azure performance... but it's getting out of hand. Does not resolve but is connected to the perma-issue #428.

Approach

Pre review checklist

ertomatic commented 1 year ago

Can one of the admins verify this patch?

kwinkunks commented 1 year ago

Three tests timed out, so will increase the timeout in the workflow and see if that fixes it.

Also Selenium seems to be throwing a lot of warnings, non-fatal.

kwinkunks commented 1 year ago

Doubled both timeouts (implicit and explicit) and two tests are failing. I don't tihnk the yare flaky / performance related, and they failed on the last PR before this one too, but I can't see what the issue is right now. I cannot reproduce it locally.

hnformentin commented 1 year ago

As tests are failing, I would think it is not ready for review. I will move to todo, sorry if it was a mistake from my side.

kwinkunks commented 11 months ago

Closing this because we are no longer experiencing these flakinesses.