Closed kwinkunks closed 11 months ago
Can one of the admins verify this patch?
Three tests timed out, so will increase the timeout in the workflow and see if that fixes it.
Also Selenium seems to be throwing a lot of warnings, non-fatal.
Doubled both timeouts (implicit and explicit) and two tests are failing. I don't tihnk the yare flaky / performance related, and they failed on the last PR before this one too, but I can't see what the issue is right now. I cannot reproduce it locally.
As tests are failing, I would think it is not ready for review. I will move to todo, sorry if it was a mistake from my side.
Closing this because we are no longer experiencing these flakinesses.
Issue Timeouts were set in a few different places, and we're trying to change them and add others to cope with Azure performance... but it's getting out of hand. Does not resolve but is connected to the perma-issue #428.
Approach
conftest.py
testkomodo.sh
script detects the$CI_RUNNER_LABEL
env var has the valueazure
wait_a_bit
function which added custom sleepsPre review checklist