search

equinor / webviz-ert

ERT webviz plugins
GNU General Public License v3.0
13 stars 25 forks source link

Integration test fails with new ert storage #434

Closed kwinkunks closed 1 year ago

kwinkunks commented 1 year ago

Describe the bug Integration test SPE1 results in:

ERROR tests/test_webviz_ert.py::test_webviz_parameter_comparison - ImportError: cannot import name 'Storage' from 'ert.services' (/prog/res/komodo/2023.06.rc1-py38-rhel7/root/lib64/python3.8/site-packages/ert/services/__init__.py)
ERROR tests/test_webviz_ert.py::test_webviz_response_correlation - ImportError: cannot import name 'Storage' from 'ert.services' (/prog/res/komodo/2023.06.rc1-py38-rhel7/root/lib64/python3.8/site-packages/ert/services/__init__.py)
ERROR tests/test_webviz_ert.py::test_webviz_response_comparison - ImportError: cannot import name 'Storage' from 'ert.services' (/prog/res/komodo/2023.06.rc1-py38-rhel7/root/lib64/python3.8/site-packages/ert/services/__init__.py)
ERROR tests/test_webviz_ert.py::test_webviz_observation_analyzer - ImportError: cannot import name 'Storage' from 'ert.services' (/prog/res/komodo/2023.06.rc1-py38-rhel7/root/lib64/python3.8/site-packages/ert/services/__init__.py)

To Reproduce Run the integration test with ert4 and ert5

Expected behavior Tests should pass

From Zohar:

We can do a

try:
  from ert.services import StorageService as Storage
except ImportError:
  from ert.services import Storage

to cover both ERT4 and ERT5