search

equinor / webviz-ert

ERT webviz plugins
GNU General Public License v3.0
12 stars 23 forks source link

Pin urllib3 < 2 #443

Closed oysteoh closed 8 months ago

oysteoh commented 8 months ago

urllib3 needs to be pinned below v2 due to incompabilites with RHEL7

berland commented 8 months ago

FYI, in the github action workflow that tests webviz-ert, urllib3 is already pinned, but pip still installs a newer urllib3.[

https://github.com/equinor/komodo-releases/blob/e39c27012e15aeea78d863a2c236a5aacf89fd61/.github/workflows/run_tests_one_project.yml#L102

oysteoh commented 8 months ago

FYI, in the github action workflow that tests webviz-ert, urllib3 is already pinned, but pip still installs a newer urllib3.[

https://github.com/equinor/komodo-releases/blob/e39c27012e15aeea78d863a2c236a5aacf89fd61/.github/workflows/run_tests_one_project.yml#L102

I guess it is because the new version is installed through a dependency when installing webviz-ert, and by pinning it this should now be solved? Or am i thinking wrong here?

oyvindeide commented 8 months ago

Some test dependency must install a newer version then?

oysteoh commented 8 months ago

Some test dependency must install a newer version then?

i.e selenium uses requests which uses urllib3 - so i guess it is pulled down when running the tests. Updated the PR to add the pinning there instead.