Closed kwinkunks closed 8 months ago
I guess we run with set -e and curl returns 1 when the file is 404. So this version always returns true from the curl, and we don't exit. Fixes #457.
Issue Resolves #457
Approach Main thing was adding the || true to the curl --head that tests the download.
|| true
curl --head
Also allowing other versions of HTTP as I bet it's actually 1.1 -- so even the 'file exists' case might have failed before in fact.
I guess we run with set -e and curl returns 1 when the file is 404. So this version always returns true from the curl, and we don't exit. Fixes #457.
Issue Resolves #457
Approach Main thing was adding the
|| trueto thecurl --headthat tests the download.Also allowing other versions of HTTP as I bet it's actually 1.1 -- so even the 'file exists' case might have failed before in fact.
Pre review checklist