search

equinor / webviz-subsurface-components

Custom subsurface visualizations for use in Webviz and/or Dash.
https://github.com/orgs/equinor/projects/24
Mozilla Public License 2.0
33 stars 39 forks source link

Slider not cell phone friendly, add click-zone? #119

Open asnyv opened 4 years ago

asnyv commented 4 years ago

Current https://github.com/equinor/webviz-subsurface-components/blob/master/src/lib/private_components/shared/slider.js is not reliable on cell phones, consider to add clickable zones.

aprilzhang commented 3 years ago

Are we interested in using Material UI for handling the user interfaces? In particular, in this case https://material-ui.com/components/slider/ might be an option to consider. Material UI is a popular React UI framework and it has mature support for mobile devices.

HansKallekleiv commented 3 years ago

This is a good question @aprilzhang The slider component in this repository is old and inherited from a discontinued project for building static web pages.

Ideally in Equinor we would like to use the Equinor design system for these types of components. Other companies (including Emerson) would probably prefer other design systems.

I think the focus of this repository should be domain specific components such as the map component and we should import "user interface" components such as sliders from other sources.

If we should choose a specific design system or try to keep it agnostic enough to switch between systems is something we can discuss in the team. I'm not sure how difficult that would be technically.