jorgenherje
commented
8 months ago When performing the initial splitting, I started looking into converting grup_tree.js to typescript. This work can pinpoint some of the issues detected when trying to purely convert the .js implementation into .ts. E.g. the existing .js code directly manipulates d3 objects used, by adding new attributes etc in code. This is not allowed when using typescript.
Here is the testing branch: https://github.com/CeetronSolutions/webviz-subsurface-components/tree/split-group-tree-setting-and-view-ts-conversion-backup
Initial converting GroupTree.ts: https://github.com/CeetronSolutions/webviz-subsurface-components/blob/split-group-tree-setting-and-view-ts-conversion-backup/typescript/packages/group-tree/src/components/group-tree-plot/src/Plot/GroupTree.ts
The drawing class in
groupTreeAssembler.jsutilized inGroupTreePlotdoes not support resizing. It does only use the initial width and height of the element it is rendered in and does not adjust to changes of the parent element. This can lead to bad UX, especially in the dynamic new Webviz application.In addition, the class' code is difficult to adjust and maintain since it is written in plain JavaScript.
I suggest to: