search

equinor / webviz-subsurface-components

Custom subsurface visualizations for use in Webviz and/or Dash.
https://github.com/orgs/equinor/projects/24
Mozilla Public License 2.0
39 stars 40 forks source link

WellLogViewer, Typescript - Wrong type definitions #2259

Closed Anders2303 closed 1 month ago

Anders2303 commented 1 month ago

Some of the exported types in the projects are incorrect, compared to what is actually valid for the options (atleast as far as I can see)

In WellLogTypes.ts, discrete objects are typed to an empty array, but it should be Record<string, any[]>

export type WellLogMetadataDiscreteObjects = Record<string, []>;

In WellLogTemplateTypes.ts, both color and type is required, but you'd want to omit them if you're using the style property

export type TemplatePlotProps = {
    type: TemplatePlotTypes;
    // ...
    color: CSSColor;
    // ...
};
hkfb commented 1 month ago

:tada: This issue has been resolved in version wsc-common@1.0.0 :tada:

The release is available on GitHub release

hkfb commented 1 month ago

:tada: This issue has been resolved in version subsurface-viewer@1.0.0 :tada:

The release is available on GitHub release

hkfb commented 1 month ago

:tada: This issue has been resolved in version well-log-viewer@2.0.0 :tada:

The release is available on GitHub release