Closed Anders2303 closed 1 month ago
NOTE: This PR is relevant for issue #1032 , but does not solve it, For now, if the same curve-name exists in multiple sets, the viewer will always use the first one it locates, meaning comparing to runs will not work (unless you give them distinct names, of course). This is moreso an issue with how the template is handled, and felt out of scope for this PR
Could you create a story that demonstrates the usage and the format of the multi log set format? Could be a simple synthetic example, eg. showing discrete and continuous curves in the same track.
Could you create a story that demonstrates the usage and the format of the multi log set format? Could be a simple synthetic example, eg. showing discrete and continuous curves in the same track.
@hkfb I did, it's under /story/welllogviewer-demo-welllogviewer--multiple-well-log
.
Overall remark: types/interfaces nicely use WellLog camelcase most members/var are not camelcase, leading to use welllog with a triple lll) :/
Suggest adding something like
BREAKING CHANGE:
- breaking API change ...
- another breaking API change ...
to the PR description.
This should trigger a major release of the package, following the Angular semantic release convention.
Suggest adding something like
BREAKING CHANGE:
- breaking API change ...
- another breaking API change ...
to the PR description.
This should trigger a major release of the package, following the Angular semantic release convention.
I made it so welllog
is backwards compatible, so the PR shouldn't be breaking
:tada: This issue has been resolved in version well-log-viewer@2.1.0 :tada:
The release is available on GitHub release
Per the JSON-welllog standard, a well-log can be a set of multiple distinct well-log sets. This update changes the well-log viewer component (and related logic) to accept a list of sets. This change will allow library users to display curves from well-logs with different sampling rates without needing to do perform any resampling.
Changes
WellLogViewer
componentWellLog
type in favor of the more preciseWellLogCollection
andWellLogSet
(The latter being the replacement for the deprecatedWellLog
)welllog
prop now accepts either aWellLogSet
or aWellLogCollection
SyncLogViewer
and other exported components can now support an array of well-log collectionstracks.ts
util file is the most affected, naturally. It has also gotten some general clean-up; moved some duplicated code into helper function, and improved some code readabilityMapAndWellLogViewer
component logic out to it's own file to make the Well-log viewer storybook code easier to readA Storybook example of multiple logs can be found on
/story/welllogviewer-demo-welllogviewer--multiple-well-log