equinor / webviz-subsurface-components

Custom subsurface visualizations for use in Webviz and/or Dash.
https://github.com/orgs/equinor/projects/24
Mozilla Public License 2.0
39 stars 40 forks source link

feat: Well log viewer - multiple well log support #2279

Closed Anders2303 closed 1 month ago

Anders2303 commented 1 month ago

Per the JSON-welllog standard, a well-log can be a set of multiple distinct well-log sets. This update changes the well-log viewer component (and related logic) to accept a list of sets. This change will allow library users to display curves from well-logs with different sampling rates without needing to do perform any resampling.

Changes

A Storybook example of multiple logs can be found on /story/welllogviewer-demo-welllogviewer--multiple-well-log

Anders2303 commented 1 month ago

NOTE: This PR is relevant for issue #1032 , but does not solve it, For now, if the same curve-name exists in multiple sets, the viewer will always use the first one it locates, meaning comparing to runs will not work (unless you give them distinct names, of course). This is moreso an issue with how the template is handled, and felt out of scope for this PR

hkfb commented 1 month ago

Could you create a story that demonstrates the usage and the format of the multi log set format? Could be a simple synthetic example, eg. showing discrete and continuous curves in the same track.

Anders2303 commented 1 month ago

Could you create a story that demonstrates the usage and the format of the multi log set format? Could be a simple synthetic example, eg. showing discrete and continuous curves in the same track.

@hkfb I did, it's under /story/welllogviewer-demo-welllogviewer--multiple-well-log.

w1nklr commented 1 month ago

Overall remark: types/interfaces nicely use WellLog camelcase most members/var are not camelcase, leading to use welllog with a triple lll) :/

hkfb commented 1 month ago

Suggest adding something like

BREAKING CHANGE:

  • breaking API change ...
  • another breaking API change ...

to the PR description.

This should trigger a major release of the package, following the Angular semantic release convention.

Anders2303 commented 1 month ago

Suggest adding something like

BREAKING CHANGE:

  • breaking API change ...
  • another breaking API change ...

to the PR description.

This should trigger a major release of the package, following the Angular semantic release convention.

I made it so welllog is backwards compatible, so the PR shouldn't be breaking

hkfb commented 1 month ago

:tada: This issue has been resolved in version well-log-viewer@2.1.0 :tada:

The release is available on GitHub release