Slowdown in `Intersection` module's Well-pick layer

[Anders2303]

Adding a well-pick layer to the Intersection module causes significant frame-drops

• If the module's settings are open, the settings component's Tree RC count keeps increasing, so there's a re-render loop being triggered somewhere
• Additionally, just having the well-pick layer enabled, cause the entire app to behave slower (without Intersection's settings being open). The view's debug info is stable, so the slowdown is happening somewhere else, but you can clearly see things slowing down when moving the graph around

[Anders2303]

For the settings, could it be this line from wellpicksLayer.tsc?

    const [newSettings, setNewSettings] = React.useState<Partial<WellpicksLayerSettings>>({});
    // ...
    React.useEffect(
        function propagateSettingsChange() {
            props.layer.maybeUpdateSettings(newSettings);
            props.layer.maybeRefetchData();
            setNewSettings({});
        },
        [newSettings, props.layer]
    );

Wouldnt this effect cause itself to always re-trigger, since it both depends on newSettings, and sets it to a new object every time?

[rubenthoms]

Duplicate of #721 but with more info.

[rubenthoms]

For the settings, could it be this line from wellpicksLayer.tsc?

    const [newSettings, setNewSettings] = React.useState<Partial<WellpicksLayerSettings>>({});
    // ...
    React.useEffect(
        function propagateSettingsChange() {
            props.layer.maybeUpdateSettings(newSettings);
            props.layer.maybeRefetchData();
            setNewSettings({});
        },
        [newSettings, props.layer]
    );

Wouldnt this effect cause itself to always re-trigger, since it both depends on newSettings, and sets it to a new object every time?

Looks like a plausible candidate :+1: