Closed tnatt closed 8 months ago
Do you also need to remove the argument from
Grid().from_roxar()
?You might also consider adding this to the migration guide, even if the impact is small.
Nice catch, did not notice that one .. it will be good when we can turn on more pylint options trough ruff to pick up on these 👍 I will add it to the migration guide!
Attention: 5 lines
in your changes are missing coverage. Please review.
Comparison is base (
7e1c87e
) 80.02% compared to head (96ada09
) 80.00%.
Files | Patch % | Lines |
---|---|---|
src/xtgeo/grid3d/grid.py | 16.66% | 4 Missing and 1 partial :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
The
dimensions_only
argument available inxtgeo.grid_from_roxar()
does not work, and this PR resolves #1042.Its intended use of this argument was to create a grid with correct dimensions that could be used as a template for a new GridProperty. By only extracting the dimensions of a grid, the users could get a performance increase.
Extracting dimensions from a grid is pretty straightforward with the roxar API, hence this bug will not be fixed.
This PR adds a deprecation warning to the
dimensions_only
argument, and removes all code related to this argument sincedimensions_only=True
did not work anyway.dimensions_only=True
but instead set it todimensions_only=False
when they got an error message