equinor / xtgeo

XTGeo Python class library for subsurface Surfaces, Cubes, Wells, Grids, Points, etc
https://xtgeo.readthedocs.io/en/latest/
GNU Lesser General Public License v3.0
110 stars 56 forks source link

CLN: Refactor and type `_gridprop_export` #1116

Closed mferrera closed 8 months ago

mferrera commented 8 months ago

These functions did not support memory streams which made only typing them not possible. Some changes needed to be made to support writing and appending to streams as well.

Adds to #1011

codecov-commenter commented 8 months ago

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (749b73e) 80.16% compared to head (58f62fc) 80.13%.

Files Patch % Lines
src/xtgeo/grid3d/_gridprop_export.py 84.37% 6 Missing and 4 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1116 +/- ## ========================================== - Coverage 80.16% 80.13% -0.03% ========================================== Files 96 96 Lines 13580 13575 -5 Branches 2196 2193 -3 ========================================== - Hits 10886 10878 -8 - Misses 1961 1964 +3 Partials 733 733 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.