Closed tnatt closed 8 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
03624f7
) 80.14% compared to head (a08dab0
) 80.13%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
There is a lot of common functionality related to roxapi inside the xyz and regular_surface modules e.g. validating input, checking if the requested name/category exists in the RMS project and retrieving folders and objects from the project. I did not move this functionality now, but we should consider doing it in a later PR. Maybe the RoxUtils would be a nice place for it?
There is a lot of common functionality related to roxapi inside the xyz and regular_surface modules e.g. validating input, checking if the requested name/category exists in the RMS project and retrieving folders and objects from the project. I did not move this functionality now, but we should consider doing it in a later PR. Maybe the RoxUtils would be a nice place for it?
Sure, good point
PR that adds the support of reading
well_picks
from RMS asxtgeo.Points
, and writing them back. Closes #1108Also some refactoring of existing code was performed:
get_roxitem()
andget_roxxyz()
into oneOther:
to_roxar()
andfrom_roxar()
as list.category=["My folder", "My subfolder"]
works now and is equal tocategory="My folder/My subfolder"
Example usage: