equinor / xtgeo

XTGeo Python class library for subsurface Surfaces, Cubes, Wells, Grids, Points, etc
https://xtgeo.readthedocs.io/en/latest/
GNU Lesser General Public License v3.0
110 stars 56 forks source link

ENH: Roxar well picks support #1117

Closed tnatt closed 8 months ago

tnatt commented 8 months ago

PR that adds the support of reading well_picks from RMS as xtgeo.Points, and writing them back. Closes #1108

Also some refactoring of existing code was performed:

Other:

Example usage: Snag_5476882

codecov-commenter commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (03624f7) 80.14% compared to head (a08dab0) 80.13%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1117 +/- ## ========================================== - Coverage 80.14% 80.13% -0.02% ========================================== Files 96 96 Lines 13575 13575 Branches 2193 2193 ========================================== - Hits 10880 10878 -2 - Misses 1963 1964 +1 - Partials 732 733 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

tnatt commented 8 months ago

There is a lot of common functionality related to roxapi inside the xyz and regular_surface modules e.g. validating input, checking if the requested name/category exists in the RMS project and retrieving folders and objects from the project. I did not move this functionality now, but we should consider doing it in a later PR. Maybe the RoxUtils would be a nice place for it?

jcrivenaes commented 8 months ago

There is a lot of common functionality related to roxapi inside the xyz and regular_surface modules e.g. validating input, checking if the requested name/category exists in the RMS project and retrieving folders and objects from the project. I did not move this functionality now, but we should consider doing it in a later PR. Maybe the RoxUtils would be a nice place for it?

Sure, good point