search

equinor / xtgeo

XTGeo Python class library for subsurface Surfaces, Cubes, Wells, Grids, Points, etc
https://xtgeo.readthedocs.io/en/latest/
GNU Lesser General Public License v3.0
109 stars 56 forks source link

FIX: Regression fix on #1117 #1123

Closed tnatt closed 6 months ago

tnatt commented 6 months ago

Fix bug caused by #1117, and add tests to avoid issue in future.

tnatt commented 6 months ago

LGTM. I would think the prefix of commit message ~shall be BUG, not FIX~. Edit: split into two commits, one for each file and let the test have prefix TST, and the _xyz_roxapi.py have label BUG.

Thanks I will 👍

codecov-commenter commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (21f1f99) 80.12% compared to head (25c3f1c) 80.12%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1123 +/- ## ======================================= Coverage 80.12% 80.12% ======================================= Files 96 96 Lines 13580 13580 Branches 2196 2196 ======================================= Hits 10881 10881 Misses 1964 1964 Partials 735 735 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.