search

equinor / xtgeo

XTGeo Python class library for subsurface Surfaces, Cubes, Wells, Grids, Points, etc
https://xtgeo.readthedocs.io/en/latest/
GNU Lesser General Public License v3.0
109 stars 56 forks source link

CLN: Create and return bulkvol array from C++ #1133

Closed mferrera closed 6 months ago

mferrera commented 6 months ago

Allows for a more Pythonic way of working on the Python side. No change in performance

tests/test_grid3d/test_grid.py::test_benchmark_bulkvol Before:

------------------------------------------------- benchmark 'bulkvol': 1 tests ------------------------------------------------
Name (time in us)               Min       Max      Mean   StdDev    Median      IQR  Outliers  OPS (Kops/s)  Rounds  Iterations
-------------------------------------------------------------------------------------------------------------------------------
test_benchmark_bulkvol     639.5000  786.2080  654.6035  15.0888  648.2500  20.5520    117;15        1.5276     821           1
-------------------------------------------------------------------------------------------------------------------------------

Legend:
  Outliers: 1 Standard Deviation from Mean; 1.5 IQR (InterQuartile Range) from 1st Quartile and 3rd Quartile.
  OPS: Operations Per Second, computed as 1 / Mean

After:

------------------------------------------------- benchmark 'bulkvol': 1 tests ------------------------------------------------
Name (time in us)               Min       Max      Mean   StdDev    Median      IQR  Outliers  OPS (Kops/s)  Rounds  Iterations
-------------------------------------------------------------------------------------------------------------------------------
test_benchmark_bulkvol     638.5420  796.9161  669.0980  24.5307  666.0835  45.5831     333;1        1.4945     788           1
-------------------------------------------------------------------------------------------------------------------------------
codecov-commenter commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (d1b983a) 80.26% compared to head (55e0512) 80.26%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1133 +/- ## ========================================== - Coverage 80.26% 80.26% -0.01% ========================================== Files 97 97 Lines 13572 13571 -1 Branches 2177 2177 ========================================== - Hits 10894 10893 -1 Misses 1955 1955 Partials 723 723 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.