Closed mferrera closed 6 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
0af8d2f
) 80.28% compared to head (16df165
) 80.30%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
No particular fixation with the bulkvol function, just have to start somewhere and this was a good spot. But the main focus of this PR is to expand the pybind11 setup into something more scalable. This format will probably change later, too. Minor performance improvement.
Resolves #1137 Adds to #1138
Old:
New:
Taking the medians at face value, in sum these changes made the function 30% faster from where it started with the SWIG C binding.