Closed tnatt closed 7 months ago
Attention: 10 lines
in your changes are missing coverage. Please review.
Comparison is base (
33652a2
) 80.08% compared to head (f79b42b
) 80.01%. Report is 4 commits behind head on main.
Files | Patch % | Lines |
---|---|---|
src/xtgeo/grid3d/_grid_boundary.py | 68.75% | 7 Missing and 3 partials :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
PR which resolves #925 and adds a new method
grid.get_boundary_polygons()
for extracting boundary polygons from a grid instance.Key notes:
surf.get_boundary_polygons()
except added an optionalfilter_array
argument for defining a specific part of the grid that the boundary should be extracted from e.g. a region or around specific conditions.grid.get_xyz()
,grid.get_dx()
andgrid.get_dy()
to speed up performance when the method is run multiple times in loop with different filter_array input (e.g. looping over and creating region polygons).This new method forms the basis for a potential future method with a more simplified user-interface for extracting boundaries around unique values in a discrete property. This should be added after adding support for polygon attributes #900, so that we can have a
NAME
attribute that corresponds to the code name.