FIX: Ensure cube scanning paths are strings

equinor / xtgeo

XTGeo Python class library for subsurface Surfaces, Cubes, Wells, Grids, Points, etc

https://xtgeo.readthedocs.io/en/latest/

GNU Lesser General Public License v3.0

109 stars 56 forks source link

FIX: Ensure cube scanning paths are strings #1181

Closed mferrera closed 4 months ago

mferrera commented 4 months ago

Resolves #1178

Notably this does not work with streams -- but it never did and requires a larger refactor in order to do so. Fixing that is probably not worth while for code that will soon be deprecated.

codecov-commenter commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (4196910) 80.02% compared to head (62790cc) 80.02%.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #1181 +/- ## ======================================= Coverage 80.02% 80.02% ======================================= Files 98 98 Lines 13680 13680 Branches 2197 2197 ======================================= Hits 10947 10947 Misses 2002 2002 Partials 731 731 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

janbjorge commented 4 months ago

Not picked up by mypy since we have not started type annotation work in this part of the code yet?

mferrera commented 4 months ago

Not entirely sure what you mean, but yes, but it's also correctly annotated for strings anyway. The problem is that string paths and pathlib.Paths are used so interchangeably with xtgeo I thought might as well put the stringify in xtgeo 3.0 here anyway since the type annotations are mostly irrelevant to most users who are just editing code in the RMS Python box, plus it gives an unhelp error from C.