codecov-commenter
commented
2 months ago Codecov Report
Attention: Patch coverage is 83.33333% with 2 lines in your changes are missing coverage. Please review.
Project coverage is 80.01%. Comparing base (
0375fed) to head (193dca5).:exclamation: Current head 193dca5 differs from pull request most recent head e7eda02. Consider uploading reports for the commit e7eda02 to get more accurate results
| Files | Patch % | Lines |
|---|---|---|
| src/xtgeo/grid3d/_grid_etc1.py | 80.00% | 1 Missing and 1 partial :warning: |
Additional details and impacted files
```diff @@ Coverage Diff @@ ## main #1197 +/- ## ========================================== - Coverage 80.02% 80.01% -0.02% ========================================== Files 98 98 Lines 13680 13692 +12 Branches 2203 2204 +1 ========================================== + Hits 10948 10956 +8 - Misses 1999 2001 +2 - Partials 733 735 +2 ```:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This is a PR to address an urgent need in am ongoing top-prioritized project, where current solutions using numpy operations combined with existing
xtgeofunctionality become too memory demanding. The C++ function here in this PR will solve this in a much more lean and memory and CPU friendly manner.There is also a commit that modifies the macos tests. They fail initially due installation issues with pytables and HDF5.