search

equinor / xtgeo

XTGeo Python class library for subsurface Surfaces, Cubes, Wells, Grids, Points, etc
https://xtgeo.readthedocs.io/en/latest/
GNU Lesser General Public License v3.0
109 stars 56 forks source link

STY: Update to new ruff #1210

Closed mferrera closed 1 week ago

codecov-commenter commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 80.06%. Comparing base (0375fed) to head (5f9702b). Report is 9 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1210 +/- ## ========================================== + Coverage 80.02% 80.06% +0.03% ========================================== Files 98 98 Lines 13680 13672 -8 Branches 2203 2198 -5 ========================================== - Hits 10948 10946 -2 + Misses 1999 1992 -7 - Partials 733 734 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mferrera commented 1 week ago

I agree, and in general I am not a fan of putting so much logic in the return statement. I think we should take a look at removing or changing the rule(s) where this style is being enforced.