search

equinor / xtgeo

XTGeo Python class library for subsurface Surfaces, Cubes, Wells, Grids, Points, etc
https://xtgeo.readthedocs.io/en/latest/
GNU Lesser General Public License v3.0
109 stars 57 forks source link

BUG: fix 2 issues w.r.t. points/lines from wells, mostly in RMS settings #1213

Closed jcrivenaes closed 3 months ago

jcrivenaes commented 3 months ago

Closes #1211 Closes #1212

In addition, some refactoring of tests and fixtures was done for Roxar API integration tests, and this work should continue later.

codecov-commenter commented 3 months ago

Codecov Report

Attention: Patch coverage is 52.63158% with 9 lines in your changes missing coverage. Please review.

Project coverage is 80.03%. Comparing base (0375fed) to head (dfd98b1). Report is 10 commits behind head on main.

Files Patch % Lines
src/xtgeo/xyz/points.py 50.00% 2 Missing and 2 partials :warning:
src/xtgeo/xyz/_xyz.py 25.00% 3 Missing :warning:
src/xtgeo/well/well1.py 0.00% 1 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1213 +/- ## ========================================== + Coverage 80.02% 80.03% +0.01% ========================================== Files 98 98 Lines 13680 13682 +2 Branches 2203 2202 -1 ========================================== + Hits 10948 10951 +3 + Misses 1999 1996 -3 - Partials 733 735 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mferrera commented 3 months ago

I think you will need to adjust the text in your PR comment to have the issues auto-closed though; looks like "Closing" doesn't work but "Closes" probably should