codecov-commenter
commented
2 months ago Codecov Report
Attention: Patch coverage is 92.00000% with 2 lines in your changes missing coverage. Please review.
Project coverage is 80.04%. Comparing base (
0375fed) to head (cb916de). Report is 15 commits behind head on main.
| Files | Patch % | Lines |
|---|---|---|
| src/xtgeo/grid3d/_grid_wellzone.py | 75.00% | 1 Missing :warning: |
| src/xtgeo/xyz/_xyz_data.py | 66.66% | 1 Missing :warning: |
Additional details and impacted files
```diff @@ Coverage Diff @@ ## main #1217 +/- ## ========================================== + Coverage 80.02% 80.04% +0.01% ========================================== Files 98 98 Lines 13680 13683 +3 Branches 2203 2202 -1 ========================================== + Hits 10948 10952 +4 + Misses 1999 1996 -3 - Partials 733 735 +2 ```:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Resolves #1216
Reduces the number of warnings from 4000 to 1500. The remaining ones are mostly self-emitted for xtgeo 4.0 deprecations, with a few numpy ones.
A big-looking change is the removal of
inplace=arguments. See the commit comment for a longer description, but tl;dr this didn't actually do things inplace but on a copy internally. See https://github.com/pandas-dev/pandas/pull/51466