Bug Fix: Custom column name fails to generate UIDs.

[chunpan]

The Problem:

The custom uid column feature fails to generate uids when used in a real Rails application.

Analysis:

• There were hard-coded public_uid default column names still exist in the SetPublicUid service, as well as the generate.rake task.
• Due to the way test DB was set up, a shared users table was created with both public_uid and custom_uid, therefore causing this bug to be disguised.
• There were no tests specifically for generate_uid in the model with custom_uid column.
• There were no tests for the generate.rake task.

Solution:

• Test tables are now separated to have 3 scenarios:
  • Without any uid column.
  • With default public_uid column.
  • With custom custom_uid column.
• This enables real-life tests that will not obfuscate no such column or unknown attribute type of errors that I've seen in my Rails app.
• Unit tests are added for the model with custom_uid column.
• Rake tests are added to simulate the generation of either public_uid or custom_uid values for existing records that don't have these values.
• Remove redundant test model class that is not used.
• TDD: Without a code fix, 6 tests would fail.
• TDD: After fixing SetPublicUid and generate.rake task, all tests would pass.
• Minor build version bump.

[equivalent]

good spot, nice piece of work.

I will have no look at this PR in depth over this Weekend as this Gem is significant in many projects. But in principle you are right that was a bug

[equivalent]

gem 1.2.2 released https://rubygems.org/gems/public_uid/versions/1.2.2

thank you once again ;)