er-muyue / DeFRCN

MIT License
182 stars 43 forks source link

where is the `PCB` module? #7

Closed Wei-i closed 2 years ago

Wei-i commented 2 years ago

Hi, I am sorry that I can not find the code where the PCB module for re-weighting the box-predictor' cls scores refers to. Hope someone who knows could help me :), thx.

er-muyue commented 2 years ago

Hi, you can find the PCB module here, and this line executes the calibration operation.

Wei-i commented 2 years ago

oh! Thanks a lot! But this makes me strange because PCB module executes during inference. When I read your paper, I thought it may be a common module like 'channel wise add' or 'reweighting' during training.

Wei-i commented 2 years ago

My question is that when we reweight the score using PCB module, why can we improve AP? I think during inference, for instance the input is a image while the output is the list of proposals, each proposal has score, pred label and pred box. I am confused that I think coco eval api does not care about the scores for a proposal because label and bbox is certain. What is wrong with my view?

er-muyue commented 2 years ago

In fact, it does affect. The score represents the confidence of each dt, which will be utilized to re-index dt-bboxes by cocoeval-api (sort dt highest score first, sort gt ignore last). Please see these code (or code) in cocoeval-api.

Wei-i commented 2 years ago

Thanks you :)