search

eracknaphobia / plugin.video.mlbtv

MLB.tv KODI add-on
GNU General Public License v2.0
19 stars 12 forks source link

List favorite team's game(s) first #43

Closed thromer closed 2 years ago

tonywagner commented 2 years ago

This one may not be necessary, as my latest pull request includes an "autoplay favorite team when live" option, as requested: https://github.com/eracknaphobia/plugin.video.mlbtv/pull/44

thromer commented 2 years ago

This one may not be necessary, as my latest pull request includes an "autoplay favorite team when live" option, as requested: #44

I think #43 would still be useful on its own, since autoplay doesn't always apply.

tonywagner commented 2 years ago

That makes sense. Since my PR also modified the create_game_listitem function, I just rolled your changes into my PR, if you want to update and test.

thromer commented 2 years ago

Thanks! My laptop just went belly-up so I won't be able to test it unfortunately.

tonywagner commented 2 years ago

No problem, I think I've watched enough baseball to test it thoroughly the past few days. :)

In any case, I think this PR can be closed now. Thanks for the contribution!

eracknaphobia commented 2 years ago

@thromer @tonywagner Thanks for the updates! So we are closing this PR and pulling #44, correct?

tonywagner commented 2 years ago

So we are closing this PR and pulling #44, correct?

Yes, https://github.com/eracknaphobia/plugin.video.mlbtv/pull/44 now incorporates the changes from this PR too