eracknaphobia / plugin.video.nhlgcl

Watch NHL.tv in KODI
GNU General Public License v2.0
25 stars 17 forks source link

Unable to generate game thumbnails - Error Thrown #34

Closed feerlessleadr closed 3 years ago

feerlessleadr commented 3 years ago

Hi - I found an issue where I'm unable to generate game thumbnails through the addon settings using the latest version of the addon for Matrix.

Here is a log on my test Windows system:

https://paste.ubuntu.com/p/JjX43SBSrQ/

Thanks

eracknaphobia commented 3 years ago

You're running version 2021.5.7, the latest version (2021.10.1) is still in the process of being accepted into the kodi repo, should fix this issue.

feerlessleadr commented 3 years ago

Thanks! It looks like your repo doesn't include the matrix version, is that correct (when I install your repo under matrix, the repo is blank, even when I refresh/update it).

eracknaphobia commented 3 years ago

This repo uses kodi addon submitter to create and update the matrix and pre-matrix branches. If you wanted to manually install the addon unzip the contents and edit the addon.xml file. change this <import addon="xbmc.python" version="2.24.0"/> to this <import addon="xbmc.python" version="3.0.0"/>

feerlessleadr commented 3 years ago

Thanks - I just grabbed the latest zip and installed (with your edit), and I'm getting the same error. I can upload another log if need be.

eracknaphobia commented 3 years ago

Yes please

feerlessleadr commented 3 years ago

Sure thing - here you go:

https://paste.ubuntu.com/p/tdqGpWH8Jh/

eracknaphobia commented 3 years ago

Thanks, I guess I should pull the generate icons option as the game icons should be automatically created now. Are you able to view the icons when selecting the actual games?

feerlessleadr commented 3 years ago

I do see them, sorry I never actually went into the game listing with the updated add-on.

On a side note though, is it possible to have the game thumbnails be wide icons/background rather than the square icons/background they are now? With the logos, the square ones look squished to me ( would he me though). Thanks either way!

eracknaphobia commented 3 years ago

Going by kodi's addon specs icons must be square: The icon size must be 256x256 pixels or 512x512 pixels.

I'm no graphic designer so i put it together the best I could. I notice shrinking the team logo's gave them jagged edges so I left them as is.

feerlessleadr commented 3 years ago

Fair enough - thanks for the info!