eracknaphobia / plugin.video.nhlgcl

Watch NHL.tv in KODI
GNU General Public License v2.0
24 stars 17 forks source link

Addon doesn't work on Kodi 21 (Android) #55

Open paarothefinc opened 1 month ago

paarothefinc commented 1 month ago

I made two clean installations of Kodi on Xiaomi Mi Box S Android box. First with Kodi 20.5 and the latest version of nhl.tv addon (v2024.4.18). Addon works ok. Then I installed Kodi 21 (again, clean install) and the same nhl.tv addon version (v2024.4.18) and the addon doesn't work.

In both installs I also installed InputStream Adaptive addon.

I attached excerpt of Kodi logs. kodi.log.zip

The main issue seems to be HTTP code 403 (forbidden), but I'm not sure:

error <general>: AddOnLog: inputstream.adaptive: [AS-0] Download failed, HTTP error 403: https://spottnhl.akamaized.net/hls/live/2096096-b/4029495_4627621/hdntl=exp=1714721761~acl=%2f*~data=hdntl~hmac=1be7da58f49e44a65fb04d9702e515e9d7899b45471abcebd5e738805e48cf0b/4627621_2000_1714606206_0000000.ts?aka_me_session_id=AAAAAAAAAADhkzRmAAAAAJ7C1epTRO8MKtcZhm6jG46aeK8VgJ%2fOgj1%2fgepSUwjQIqKtFVcxQh2NyD3bFlstDg5x3RQZb6S2&aka_msn=0&aka_hls_version=3&aka_media_format_type=hls&l2v=1&aka_media_format_type=hls&cid=36306&mid=49470669&ecid=4627621&pid=5&dtid=1&sid=475710779553&gc=91c&gsd=lCg5&grm=1&user=618943190&content=1746319

nsoeth commented 1 month ago

We need to add the manifest_headers to the stream in Kodi 21.

I created a PR with the changes. As a quick fix, open the globals.py file and aftrer line 258 add:

listitem.setProperty("inputstream.adaptive.manifest_headers", 'User-Agent=%s' % UA_PC)

paarothefinc commented 1 month ago

It looks it kinda works now, but only to a certain extent.

  1. Highlights don't always work. Sometimes I get a message "content cannot be played based on my location". Highlights always work if I watch them on my PC in the browser. I don't use VPN, btw.
  2. Sometimes full game VODs strangely stop after a few seconds and return to the menu. For instance, this game from yesterday: https://nhltv.nhl.com/en-int/video/new-york-rangers-at-carolina-hurricanes/1748616 starts normally, but after some 5 seconds, it stops and returns to the menu. Again, it works perfectly ok in the browser.
tpaniaki commented 1 month ago
  1. Sometimes full game VODs strangely stop after a few seconds and return to the menu. For instance, this game from yesterday: https://nhltv.nhl.com/en-int/video/new-york-rangers-at-carolina-hurricanes/1748616 starts normally, but after some 5 seconds, it stops and returns to the menu. Again, it works perfectly ok in the browser.

I have the same symptom but not only related to NHL.TV. I've heard reports of various live streams being similarly impacted. More likely due to InputStream in Omega but can't confirm. Have you tried with another service (MLB.TV)?

In my case, the second or third attempt tends to stabilize the stream.

paarothefinc commented 1 month ago

I only have nhl.tv subscription, and I'm from Europe where usually there are no blackout restrictions, etc. It is rather strange, both 1st and 2nd problem I encountered. I've tried to play the stream multiple times, but to no avail.

tpaniaki commented 4 weeks ago

@paarothefinc try this build in the meantime.

paarothefinc commented 4 weeks ago

Well, this build seems to work better, but not entirely ok. Full games and highlights work, but not the last highlight from the last game (avalanche@stars, 2024/05/15). It just returns me to the menu a few seconds after clicking it. Another "strange" thing is that all previous games have multiple streams (full game - ESPN, TNT, etc., highlights), but aforementioned avalanche@stars game doesn't have this extra menu to choose the stream. If I'm in full games menu and I click this game, it immediately starts the full game stream. And if I go into the highlights menu, then the highlights for this game doesn't work as I stated before.

One question: how come the build you recommended has more configuration options than the "official" version, which only has 12/24 hrs clock switch?

tpaniaki commented 4 weeks ago

One question: how come the build you recommended has more configuration options than the "official" version, which only has 12/24 hrs clock switch?

I'm not the author of the build. This came from the forum.

paarothefinc commented 3 weeks ago

Oh, I see. I didn't even know there is a thread about it in Kodi forum. So people make their own versions out of it? I wish more people would create pull requests so that more ideas could be merged into one working solution.