eracknaphobia / plugin.video.psvue

Watch PS Vue thru Kodi
GNU General Public License v2.0
11 stars 16 forks source link

Reworked badges for show/episode listings #34

Closed hackthis02 closed 6 years ago

hackthis02 commented 6 years ago

I reworked the badges for shows/episodes to show if it is a DVR or VOD. Moved the New badge to the front so it's easier to find if the show is also heavily syndicated. Removed the aired date since it's already being displayed else where on the screen. This is simply a few personal suggestions to make the menus a little easier to manage. Hopefully you agree.

snoopyjoe commented 6 years ago

Do you have a picture of the badges? I assume this will show mainly in the My DVR section. Sounds really cool and similar to the psvue website.

hackthis02 commented 6 years ago

That's kind of what I was going for. With the current layout, I would have to take out my phone to see the name of the more recent episode. Now I can just scroll to ones with New in front. It also works in the other listings. I'm simply scanning for the badge var that Sony sends us. Demos

eracknaphobia commented 6 years ago

Great work, thanks!

snoopyjoe commented 6 years ago

Awesome! Under next airings does the time each show airs not fit? From the pictures I would say that's the only thing that would top it off.

hackthis02 commented 6 years ago

I can look into that. I just assumed it was only displaying the very next show on each of the channels.

snoopyjoe commented 6 years ago

It would display both the show and at what hour it starts. It's no big deal actually since most people use Kodi18 and the EPG. Those still on 17.6 probably still use next airings.

hackthis02 commented 6 years ago

The two other things I wanted to point out was, in the My DVR view, any shows with "new" episodes get brought to top of the list. The other thing I wanted to ask about was if we removed

json_source = sorted(json_source, key=lambda k: k['airing_date'], reverse=True)

from list_episodes It would give the same sorting as the app/website.

eracknaphobia commented 6 years ago

I'm fine with that as long as @snoopyjoe doesn't have any objections.

snoopyjoe commented 6 years ago

No issues here. Anything that makes it closer reassemble the website is good to me. On my test branch I added the hour a show will air in the future. In next airings it looks fine but in My DVR the future episode is always the top episode.

hackthis02 commented 6 years ago

That makes sense since it first episode in the app too. The odd thing I saw was PSV doesn't send it as a new episode. So I'm not sure yet how to tell if it's the latest or just a rerun.

eracknaphobia commented 6 years ago

So we all good here? I noticed that the official kodi version is woefully behind (2018.3.24) and wanted to make sure this change got finalized before sending it off. @hackthis02 Do you want to make a PR to remove the json source sorting?

hackthis02 commented 6 years ago

Yeah, just added it. #35. I also have a PR on your simpsons world repo.

eracknaphobia commented 6 years ago

Ok, I'll take a look.