search

eracknaphobia / plugin.video.psvue

Watch PS Vue thru Kodi
GNU General Public License v2.0
11 stars 16 forks source link

Prefer DVR over VOD #36

Closed hackthis02 closed 5 years ago

hackthis02 commented 5 years ago

Closed caption doesn't seem to work with VOD feeds. This prefers DVR feeds when both are available.

snoopyjoe commented 5 years ago

It would be great if we can get the add-on to give a choice of DVR or VOD when opening an episode. This is how the website does it. I tried adding this many months ago because when a DVR episode had playback issues or cut a recording there was no way to choose the VOD option.

hackthis02 commented 5 years ago

I thought about that too. It is possible, but I'm not as familiar with Kodi's menu system as I'd like to be. I can start looking into this unless you kept your earlier attempt.

snoopyjoe commented 5 years ago

I don't have the code I was working on but I believe you may need to make a new function that the list episodes function calls. I'll start working on this again as my Xcode finally updated.

snoopyjoe commented 5 years ago

I got the DVR or VOD selection code working on my Testing branch. Let me know how that works on your end. I added a 10 second "autoclose" for those who let the videos play back to back without any user commands.

hackthis02 commented 5 years ago

Love it. I changed one thing to match closer to the wording of the website. main.py:120: choice = xbmcgui.Dialog().yesno("Choose your preference","Where would you like to watch this episode?", nolabel='ON DEMAND', yeslabel='DVR', autoclose=10000)

But if this works for you and @eracknaphobia then I'll close this PR and we can do with that idea.

snoopyjoe commented 5 years ago

I got the wording from the Android app, but thats better. Looks good.