eraeco / pay

Checkard is a peer-to-peer check payment system for ERA PAY.
MIT License
4 stars 0 forks source link

Open a pop-up acknowledgement + tutorial dialog when landing on page with completed check #19

Closed jazzyjackson closed 2 weeks ago

jazzyjackson commented 1 month ago

feel free to suggest / push any style changes, I'm just using the rainbow from the dialog docs :)

Screenshot 2024-04-05 at 3 58 03 AM

Hope you like the hands courtesy of DALL-E 3

When you click the button is just logs "key: magnitude", we can upgrade that to gun/get/put at your discretion.

Need to workshop the language with you before its ready to merge with master.

cloudflare-pages[bot] commented 1 month ago

Deploying pay with  Cloudflare Pages  Cloudflare Pages

Latest commit: e1f774b
Status: ✅  Deploy successful!
Preview URL: https://e56841f0.pay-cwc.pages.dev
Branch Preview URL: https://feature-analytics.pay-cwc.pages.dev

View logs

amark commented 1 month ago

interesting... IDK why I'm resistant but it is probably unhealthy attachment to 1999 HTML. I should probably just say yes... cause it... works, gets the job done, move on. But may want to discuss.

Naming: analytics to metrics no no no, no new sub folders in root lol... dump the images/art into +/help/, we'll use that to store all the upcoming tutorial/guide/instruction stuff, I think that'll be better to keep them separate from the actual features. Since we might rotate through different images, maybe slightly more verbose naming. we will NOT reuse the key we'll use a timestamp.

(deadcode?) #tray #feature that got snuck into index's CSS.

I don't know why I'm being resistant... this is a good start, but not sure. Dialog displaying is pretty jarring, tho I know that's all CSS edits. Maybe it just relates to how much we're gonna be need to reuse a similar component other places for things, we'll discuss.

Magnitude needs to be on endorsement blur, and in-memory flag (not storage) to not magnitude again. A check might be loaded several times, so shouldn't be on approve click, but I feel comfortable enough that check likely not gonna be endorsed multiple times (in some cases... try try, it fails, then try again with different bank another day, like with you) but since we're always rounding down I'm hoping even if some false positives we're still being conservative.

Question: Is your log method trap-door? As in... if we know how to inverse the log, will we get the exact amount back? If so, we need to prevent that (have lossy information, aka trapdoor, 1-way function, etc.).

while GUN does timeseries by just gun.get('table-name').set(mag) this'll become a big/long table to scan over time, we'll still do it, but I'm also tempted to do (and this is buggy if concurrent, but I think ok until we're SUPER popular deposits every < 99ms, and even if/when we can always recompute/calc based on the timeseries) to also do a thing where we ...once(function(total){ this.put(total + 23) }) so we always have a roughly correct latest sum to immediately print. I'm gonna be ballsy enough to disclose not intending on having security, so somebody could spam us with lots of fake deposit metric updates (please don't do that!), but its not like we could verify things anyways since we're not the bank.

Can you have DALLE/other generate an instruction on what NOT to do (we can add the X to it) so like same type of pic, but surrounding browser/OS/laptop in frame. Possible might want less hand and more graphic examples of viewfinder... potentially just reusable hand/phone with also transparent display and then we just CSS layer the other images we want. Current phone is pretty oldschool so my marketing brain is like "no let's make it look SEXY" but then my product brain is like "no, old school phone is clearly understandable, feels more relaxing/comfortable to follow instructions especially for any age, the point of this is clarity not art."

jazzyjackson commented 1 month ago

You can be attached to 1999, I didn't know the dialog element was new. Some old androids might not support it. It's a small switch to use jquery to alter it instead of showModal.

tray { none } was a quick hack to hide things, #tray #feature was quick hack to unhide things. I'll put it in the marketing.html so it hides itself instead.

log10 with toPrecision(2) is lossy and keeps only one decimal place so it's not fully reversible, correct

amark commented 1 month ago

really loving how the code & naming is now looking, way super cleaner.

Probably worthy of a pull to just sh!p it, but I'll probably want to refine the copy myself before actually merging and I'm gone this next week so sorry to leave this hanging. (actually, maybe do same with tray... comment out actually activating the modal, merge, then I can do clean git edits, then I can uncomment so it does display when mine is merged. I'll probably add the GUN line too.)

Tho 1 other quick favor: +/help/deposit.html not help.html since there will be lots of help components, this one is specific to deposit.

amark commented 1 month ago

oh also forgot to change analytics.html to metrics.html

amark commented 1 month ago

per the #9 discussion, we're doing metric magnitudes, while as I think "analytics" has become synonymous with spying on user behavior, we're not tracking behavior we're going to extra efforts to anonymize everything so the only thing left is purely just conservative guesses at transaction volume (not who, what, etc.).

*tho note: thats for this p2p (erm, bank-to-bank) part of Checkard. To provide the Payment Insurance and chargeback estimations and other financial dashboard/features/services I will need to reserve the right that there will be a lot of Customer data being ingested - but this is why they'd be paying us, to make use of that information for them, the community match making ("discountism" en route to Freeism - http://math.free.eco ), etc. but this free p2p feature doesn't need any of that.

amark commented 1 month ago

I don't like the modal popping up on page load, it's too jarring. Let's activate it either on endorsement focus, or blur. Probably blur.

amark commented 2 weeks ago

👍 thanks.