show both sides of check for printing a paper copy

eraeco / pay

Checkard is a peer-to-peer check payment system for ERA PAY.

MIT License

4 stars 0 forks source link

show both sides of check for printing a paper copy #32

Closed jazzyjackson closed 2 weeks ago

amark commented 2 weeks ago

rename to to print.html please (?) unless any objection? (also, why CSS commented out?)

amark commented 2 weeks ago

loving the use of the module system, BTW, for everything, from just CSS additions to JS to HTML ui. It's so great to just see a little load statement tossed into bottom of index. Feels so nice and extensible, flexible, progressively enhanced, self-contained, yum!

cloudflare-pages[bot] commented 2 weeks ago

Deploying pay with Cloudflare Pages

Latest commit:	`b9b0791`
Status:	✅ Deploy successful!
Preview URL:	https://b4eb34c4.pay-cwc.pages.dev
Branch Preview URL:	https://bugfix-printstyle.pay-cwc.pages.dev

View logs

jazzyjackson commented 2 weeks ago

oh you were right, committed while I was still debugging by just applying the css globally. scoped to just print dialog now and renamed, ready to go.

amark commented 2 weeks ago

Looks good, merging what have so far, BUT two problems:

1) my center-center allow-zoom CSS fix now causes the front side to be middle of page, and backside to be below that which bleeds past printed page margin. So maybe toss in a -margin (?)

2) the printed page still has the check as blue... should we make it white to not mess up someone's printer color?

resolve both those please!

jazzyjackson commented 2 weeks ago

Can you screenshot ? i'm unable to reproduce, production site looks good to me. @media print background: white was already set on index.html

jazzyjackson commented 2 weeks ago

nevermind I'm seeing it now, an empty check prints fine but a filled check has a bunch of margin, intriguing.