eranheres / ultra_type

0 stars 0 forks source link

Sweep: modify get_language_code to have option selection using numbers #30

Closed eranheres closed 11 months ago

eranheres commented 11 months ago

Have the selection:

  1. English
  2. Hebrew
Checklist - [X] Modify `ultra_type/view.py` ✓ https://github.com/eranheres/ultra_type/commit/04201a4483bdda82e5a1cfdb56f3090869defadc - [X] Modify `ultra_type/controller.py` ✓ https://github.com/eranheres/ultra_type/commit/a2ee62806dd2acd4b01e3991b550472f0ff8a1a3 ![Flowchart](https://raw.githubusercontent.com/eranheres/ultra_type/sweep/assets/d5cfbe5239780e9946d8f2438421071fcf2aa9298737aa17ccee725bd1e21dae_30_flowchart.svg)
sweep-mine[bot] commented 11 months ago

Here's the PR! https://github.com/eranheres/ultra_type/pull/31.

💎 Sweep Pro: I'm using GPT-4. You have unlimited GPT-4 tickets. (tracking ID: b610a790cc)

Actions (click)

Sandbox Execution X

Here are the sandbox execution logs prior to making any changes:

Sandbox logs for 7d64cac
poetry run pylint -E **/*.py 1/1 ❌ (`2`)
************* Module ultra_type.controller
ultra_type/controller.py:2:0: E0611: No name 'View' in module 'ultra_type.view' (no-name-in-module)
************* Module ultra_type.main
ultra_type/main.py:2:0: E0611: No name 'View' in module 'ultra_type.view' (no-name-in-module)

Sandbox failed, so all sandbox checks will be disabled for this issue.


Step 1: 🔎 Searching

I found the following snippets in your repository. I will now analyze these snippets and come up with a plan.

Some code snippets I looked at (click to expand). If some file is missing from here, you can mention the path in the ticket description. https://github.com/eranheres/ultra_type/blob/7d64caccbe0d4a9ad1480594fae9885104794235/ultra_type/view.py#L1-L22 https://github.com/eranheres/ultra_type/blob/7d64caccbe0d4a9ad1480594fae9885104794235/ultra_type/language.py#L1-L17 https://github.com/eranheres/ultra_type/blob/7d64caccbe0d4a9ad1480594fae9885104794235/ultra_type/controller.py#L1-L32 https://github.com/eranheres/ultra_type/blob/7d64caccbe0d4a9ad1480594fae9885104794235/README.md#L1-L20

Step 2: ⌨️ Coding


Step 3: 🔁 Code Review

I have finished reviewing the code for completeness. I did not find errors for sweep/number-based-language-selection.


🎉 Latest improvements to Sweep:


💡 To recreate the pull request edit the issue title or description. To tweak the pull request, leave a comment on the pull request. Join Our Discord