Mocks with nested interfaces having non-virtual destructors cause SEGV

Thank you for making this very well done framework! Love using it.

This issue likely isn't fixable but perhaps deserves emphasis in doc: mocking an interface's virtual destructor requires all of its parent interfaces, if any, to also have virtual destructors -- otherwise the mock dtor will SEGV.

Repro sample:

#include "fakeit.hpp"
#include <memory>
#include <functional>
#include <iostream>

using namespace fakeit;
using namespace std;

// Composition via nested interface with default (non-virtual) destructor

struct Interface1
{
    virtual void foo() = 0;
};

struct Interface2 : public Interface1
{
    virtual ~Interface2() {}
    virtual void bar() = 0;
};

struct S : public Interface2 {
    virtual ~S() {}
    void foo() {}
    void bar() {}
};

unique_ptr<Interface2, function<void(Interface2*)>> ptr(nullptr, [](Interface2 *i){ delete i; });

int main() {

    ptr.reset(new S);
    ptr.reset(); // Ok
    cout << "Non-mock new/delete ok" << endl;

    Mock<Interface2> mock;
    Fake(Dtor(mock));

    ptr.reset(&mock.get());
    ptr.reset(); // SEGV
    cout << "Mock new/delete ok" << endl;

}

eranpeer / FakeIt

Mocks with nested interfaces having non-virtual destructors cause SEGV #123