search

eranpeer / FakeIt

C++ mocking made easy. A simple yet very expressive, headers only library for c++ mocking.
MIT License
1.24k stars 170 forks source link

Allow building on Mac or with specific GCC toolchains #132

Closed bikeNomad closed 6 years ago

bikeNomad commented 6 years ago

The existing makefiles assume a compiler and linker named g++ and an executable extension of ".exe". To allow testing on Mac or with toolchains named differently (like g++-7 for instance), this PR allows overloading of the $(LD), $(CXX), and $(EXE) make variables from the command line but otherwise defaults to the same g++/Windows build.

It also adds a clean target to the top-level makefile.

I did have to remove the linker flag -allow-multiple-definition, which isn't understood by either gcc 7 or clang.

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 99.974% when pulling ba14c694be7eb6047595039c55d9a896bd165c1b on bikeNomad:master into 33022feda7d2d19a7c15ba786e0a8ff5df075a54 on eranpeer:master.

eranpeer commented 6 years ago

Thanks, This is a great improvement.